-
Notifications
You must be signed in to change notification settings - Fork 897
DateTime in jsonldcontext #4384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
File at https://schema.org/docs/jsonldcontext.jsonld misses all "DateTime" types for every property, mostly due a mispelled case in the building script.
gmackenz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, thanks!
|
Fails in the build test. |
…teModified property
|
Seems that the test itself was broken: documentation says that |
|
tests now breaks for auditDate |
gmackenz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test has another breakage for "auditDate"
|
Ok, I totally failed to properly check my pull request... Sorry... But now, I'm a bit confused. JSON-LD specification says something about expressing a On the other hand, given my limited understanding of Ruby, seems that I've tried replacing |
|
Not sure what value the test_basics for "Date" has and if we should keep it. |
|
Anyone else have some background on test or what should be done? |
|
This pull request is being nudged due to inactivity. |
File at https://schema.org/docs/jsonldcontext.jsonld misses all "DateTime" types for every property, mostly due a mispelled case in the building script.