Skip to content

Conversation

@madbob
Copy link

@madbob madbob commented Mar 30, 2025

File at https://schema.org/docs/jsonldcontext.jsonld misses all "DateTime" types for every property, mostly due a mispelled case in the building script.

File at https://schema.org/docs/jsonldcontext.jsonld misses all "DateTime" types for every property, mostly due a mispelled case in the building script.
Copy link
Contributor

@gmackenz gmackenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks!

@gmackenz
Copy link
Contributor

Fails in the build test.

@madbob
Copy link
Author

madbob commented Apr 24, 2025

Seems that the test itself was broken: documentation says that dateModified may be both Date or DateTime, while software/tests/test_basics.py just tested for Date and failed with the "fixed" version of jsonldcontext.jsonld.

@gmackenz
Copy link
Contributor

tests now breaks for auditDate

Copy link
Contributor

@gmackenz gmackenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test has another breakage for "auditDate"

@madbob
Copy link
Author

madbob commented Apr 25, 2025

Ok, I totally failed to properly check my pull request... Sorry...

But now, I'm a bit confused.

JSON-LD specification says something about expressing a type "with an IRI", as "a term defined in the active context", or "using an array", but omits details about the contents of the array (the only available example contains IRIs, it do not mentions terms).

On the other hand, given my limited understanding of Ruby, seems that json-ld gem only accepts a single string, in form of URI, assigned to type. Arrays seems not to be handled at all, with any content.

I've tried replacing Date and DateTime with schema:Date or fully qualified URLs as http://schema.org/Date, with no success in the validation by the json-ld gem. Probably I'm missing something, but don't know what...

@gmackenz
Copy link
Contributor

Not sure what value the test_basics for "Date" has and if we should keep it.

@gmackenz
Copy link
Contributor

Anyone else have some background on test or what should be done?

@github-actions
Copy link

This pull request is being nudged due to inactivity.

@github-actions github-actions bot added the no-pr-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-pr-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants