Skip to content

Conversation

@fthobe
Copy link
Contributor

@fthobe fthobe commented Apr 29, 2025

Added sample data for extendedAddress added in #4402 .

@rrlevering @gmackenz I am unsure where to put sample data as neither of the sample files seems to be versioned or anything. I took a large approach. Could you check if I understood it correctly?

Tests seem to run correctly, but I am unsure of the correct approach here.

fthobe added 3 commits April 29, 2025 13:12
Added extendedAddress to examples.txt
Added extendedAddress to examples.txt.net
Added extendedAddress to examples.txt
@fthobe fthobe changed the title extended address example (#4397) Add extendedAddress Sample Data (#4397) Apr 29, 2025
@gmackenz
Copy link
Contributor

I think that is the location? I would look at past PRs for evidence of examples appearing in schema.org?

I wonder if it would be better to not update existing examples of address usage and instead add a specific new example of extended address usage?

@fthobe
Copy link
Contributor Author

fthobe commented Apr 29, 2025

I feel it's a very common field that never found it's way here because someone skipped a line while reading an IETF standard some 15 years ago, but being a chronical line skipper myself I align with you :)

@fthobe
Copy link
Contributor Author

fthobe commented Apr 30, 2025

@gmackenz I think your european colleagues are all out on vacation due to the long weekend 👯

@github-actions
Copy link

This pull request is being nudged due to inactivity.

@github-actions github-actions bot added the no-pr-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Jul 31, 2025
@MatthiasWiesmann
Copy link
Contributor

Hi, sorry this pull request got ignored.
Was it necessary to change the examples in the code directory?

@github-actions github-actions bot removed the no-pr-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Dec 2, 2025
@fthobe
Copy link
Contributor Author

fthobe commented Dec 16, 2025

Up to you

@fthobe
Copy link
Contributor Author

fthobe commented Dec 16, 2025

@MatthiasWiesmann yes, I went through the changes and would add the example to show that it's not meant to insert corners or anything but "C/O" or similar fields.

@MatthiasWiesmann
Copy link
Contributor

@MatthiasWiesmann yes, I went through the changes and would add the example to show that it's not meant to insert corners or anything but "C/O" or similar fields.

It's just that the examples are not used anywhere…

@fthobe
Copy link
Contributor Author

fthobe commented Dec 16, 2025

Can you elaborate? If you write me two lines where you'd like to see them I can add them.

@fthobe
Copy link
Contributor Author

fthobe commented Dec 18, 2025

Ahh shit, literally I understand now, sorry, so if we don't use them let's drop the examples fully and I edit the ones we use.
@MatthiasWiesmann

@fthobe
Copy link
Contributor Author

fthobe commented Jan 4, 2026

@MatthiasWiesmann should be fine now and be visible on respective pages as example.
https://schema.org/PostalAddress
Screenshot 2026-01-04 at 18 48 55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants