-
Notifications
You must be signed in to change notification settings - Fork 897
Add extendedAddress Sample Data (#4397) #4441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added extendedAddress to examples.txt
Added extendedAddress to examples.txt.net
Added extendedAddress to examples.txt
|
I think that is the location? I would look at past PRs for evidence of examples appearing in schema.org? I wonder if it would be better to not update existing examples of address usage and instead add a specific new example of extended address usage? |
|
I feel it's a very common field that never found it's way here because someone skipped a line while reading an IETF standard some 15 years ago, but being a chronical line skipper myself I align with you :) |
|
@gmackenz I think your european colleagues are all out on vacation due to the long weekend 👯 |
|
This pull request is being nudged due to inactivity. |
|
Hi, sorry this pull request got ignored. |
|
Up to you |
|
@MatthiasWiesmann yes, I went through the changes and would add the example to show that it's not meant to insert corners or anything but "C/O" or similar fields. |
It's just that the examples are not used anywhere… |
|
Can you elaborate? If you write me two lines where you'd like to see them I can add them. |
|
Ahh shit, literally I understand now, sorry, so if we don't use them let's drop the examples fully and I edit the ones we use. |
|
@MatthiasWiesmann should be fine now and be visible on respective pages as example. |

Added sample data for extendedAddress added in #4402 .
@rrlevering @gmackenz I am unsure where to put sample data as neither of the sample files seems to be versioned or anything. I took a large approach. Could you check if I understood it correctly?
Tests seem to run correctly, but I am unsure of the correct approach here.