Defining external classes as RDFs Classes in the schema. #4625
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MatthiasWiesmann
left a comment
MatthiasWiesmann
left a comment
There was a problem hiding this comment.
I fixed this at the code level. See #4622
Contributor
|
My reading of the code is that the post-processing phases strips these out try to run: ./software/util/buildfiles.py All and check the content of software/site/releases/29.3/schemaorg-all-http.ttl |
pascalfleury
force-pushed
the
external-classes
branch
2 times, most recently
from
ec6024b to
8beb493
Compare
Some tool choke on an externally defined class that is not marked as such in the schema. This PR adds these as classes.
pascalfleury
force-pushed
the
external-classes
branch
from
8beb493 to
b3c6ae4
Compare
Contributor
Author
|
This is unneeded now as the list of external classes is auto-computed and added in code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tool choke on an externally defined class that is not marked as such in the schema. This PR adds these as classes.
This is a mitigation of #4621.