-
Notifications
You must be signed in to change notification settings - Fork 897
Refine vatID comment for clarity and standards #4645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated the comment for vatID property to include ISO 6523 and PEPOL prefix.
MatthiasWiesmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct. ISO 6523 values with a PEPOL prefix should go into the iso6523 field. This field should only be used for VAT codes that cannot be expressed using other standards (like iso6523).
|
Sorry my mistake, I will fix or pull this later tonight. |
|
@MatthiasWiesmann in what format do you expect them here? It's hard to validate as the input alfanumeric and of variable length. The most common one used also by the EU validation API seems to pass country as two letter iso separated from the vatid itself. |
|
Basically I would suggest to do this: Instead of this As the first version is globally unambiguous. |
|
Fixed and also referenced iso6523Code |
|
Should this/these be Having said that, should we be adding to the proliferation of domain-specific identifier types when there is a standard approach to handle such needs: |
|
Honestly, reading into it I have a general question: |
|
Actually ISO 6523 is a third party solution which solves exactly the identifier structure you suggested. So the goal was to avoid adding more identifiers, it certainly makes more sense to have it at the root than say, DUNS. It also allow to distinguish cases where there are many government identifiers, like in France, where there is SIREN, SIRET. Some examples.
|
|
Yeah I saw that. The doubt that came up is that it seems like it's only consumed through special purpose systems connecting national einvoicing systems to the European interchange. Not saying it's not used, but I believe it's not really used in the web space. I align here with what you want, but I agree that maybe nesting it under identifier all together with also companyRegistration (which pains me as I just committed that) in one unified approach seems ideal. But I also see that vatID is already in use by google merchant so I don't know what can be done! |
|
On a related note, the example in https://schema.org/iso6523Code is invalid as it duplicates "iso6523Code" instead of using an array. |
|
Greetings to Australia :) Can you elaborate? |
Right, I'll send a fix. |
Fix is here for your reviewing pleasure: #4649 |
small rephrasing
|
Closing since it is a description update only. I suggest opening a new issue for the discussion about whether or not these should be a subproperty of identifier (if needed). |
Updated the comment for vatID property to include ISO 6523 and PEPOL prefix as described here: