-
Notifications
You must be signed in to change notification settings - Fork 897
Add example for Product #4660 #4662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add DPP Product example with DIDs and GS1 Digital Links for issue schemaorg#4660
|
Hi @MatthiasWiesmann, here is the example PR as requested. Ready for review! |
| <div> | ||
| <h1>Circular Smartphone</h1> | ||
| <p>Product ID (DID): did:web:verisav.fr:product:12345</p> | ||
| <p>Scan for Passport: <a href="https://id.verisav.fr/01/01234567890128/21/12345">Digital Link</a></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writing "scan" on a web page feels weird, should this not just be a link to the Product Passport?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do
| <h1 itemprop="name">Circular Smartphone</h1> | ||
| <p>Product ID (DID): <span itemprop="identifier">did:web:verisav.fr:product:12345</span></p> | ||
| <p>UUID: <span itemprop="identifier">urn:uuid:123e4567-e89b-12d3-a456-426614174000</span></p> | ||
| <p>Scan for Passport: <a itemprop="hasGS1DigitalLink" href="https://id.verisav.fr/01/01234567890128/21/12345">Digital Link</a></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do
| "@context": "https://schema.org", | ||
| "@type": "Product", | ||
| "name": "Circular Smartphone", | ||
| "description": "A repairable and circular product with Digital Product Passport (DPP) integration", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds weird, the fact that the phone has a DPP is a legal requirement, but not really a description of the product.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do
Updated links and descriptions for the Circular Smartphone product examples.
MatthiasWiesmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicks, generally good.
Please make sure all the tests pass and that the site looks ok.
Updated product information with enhanced descriptions and identifiers for better clarity and traceability.
kevinbouti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatthiasWiesmann Fixed a syntax error in data/ext/pending/issue-4660-examples.txt where the JSON-LD block was not properly closed.
Changes:
- Added missing
</script>closing tag after the JSON-LD example. - Added clear separator comments between JSON-LD and Turtle/RDF sections to prevent parsing issues.
- Verified that all formats (Microdata, RDFa, JSON-LD, Turtle) are now syntactically valid.
kevinbouti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
kevinbouti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the JSON-LD context issue by removing the custom namespace reference. All examples now use only Schema.org standard properties. Ready for review.
kevinbouti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mise à jour
Digital Product Passport Example
This PR adds an example for implementing Digital Product Passport (DPP)
in Schema.org Product type using existing properties.
Changes
identifierfor Decentralized Identifiers (DIDs)hasGS1DigitalLinkfor resolvable QR codes/NFC linksRelated to
Closes #4660